adding mask_indices routine #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnatelee
reviewed
Jun 25, 2022
magnatelee
reviewed
Jun 28, 2022
|
@ipdemes please please don't force-push changes while the changes are under a review. doing so makes it extremely difficult to look back the history. |
manopapad
reviewed
Jul 26, 2022
manopapad
reviewed
Jul 26, 2022
manopapad
reviewed
Jul 26, 2022
manopapad
requested changes
Jul 26, 2022
manopapad
reviewed
Jul 26, 2022
cunumeric/module.py
Outdated
| Notes | ||
| ----- | ||
| WARNING: `mask_indices` expects `mask_function` to call cuNumeric functions | ||
| for good performance. In case non-cuNumeric fucntions are called by |
manopapad
reviewed
Jul 27, 2022
cunumeric/module.py
Outdated
| Assume `mask_func` is a function that, for a square array a of size | ||
| ``(n, n)`` with a possible offset argument `k`, when called as | ||
| ``mask_func(a, k)`` returns a new array with zeros in certain locations | ||
| (functions like `triu` or `tril` do precisely this). Then this function |
There was a problem hiding this comment.
functions like :func:`cunumeric.triu` or :func:`cunumeric.tril`
manopapad
requested changes
Jul 27, 2022
|
@manopapad : all the tests pass after your commit. Can I merge this PR? |
|
yes, please go ahead |
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Jul 29, 2022
adding mask_indices routine
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Jul 29, 2022
adding mask_indices routine
sbak5
pushed a commit
to sbak5/cunumeric
that referenced
this pull request
Aug 17, 2022
adding mask_indices routine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@magnatelee : is this implementation align with your suggestion?